From 6b11ab7028de7df7480e380b4aa46fbd0a1dd7de Mon Sep 17 00:00:00 2001
From: Francesco Picone <francescop@qwince.com>
Date: Sat, 25 Jul 2026 19:43:29 +0200
Subject: [PATCH] ++ fix permessi assegnazioni

---
 ...e_settings_manage_from_assistente_role.php | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 database/migrations/2026_07_25_000001_revoke_settings_manage_from_assistente_role.php

diff --git a/database/migrations/2026_07_25_000001_revoke_settings_manage_from_assistente_role.php b/database/migrations/2026_07_25_000001_revoke_settings_manage_from_assistente_role.php
new file mode 100644
index 0000000..6b68760
--- /dev/null
+++ b/database/migrations/2026_07_25_000001_revoke_settings_manage_from_assistente_role.php
@@ -0,0 +1,51 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+use Spatie\Permission\Models\Permission;
+use Spatie\Permission\Models\Role;
+use Spatie\Permission\PermissionRegistrar;
+
+return new class extends Migration
+{
+    /**
+     * Guarantee that no "assistente" can modify or delete existing
+     * assignments.
+     *
+     * The only way to edit/delete an assegnazione is through the Registro's
+     * admin CRUD, which is gated on `settings.manage` (backend abort_if + the
+     * @can in registro.blade.php). By baseline the assistente role never has
+     * that permission, so an assistente can only view the registro, create new
+     * assignments (territori.assign) and return them (territori.return).
+     *
+     * RolesAndPermissionsSeeder grants additively (givePermissionTo, never
+     * syncPermissions) so it can re-run without clobbering UI-granted
+     * permissions — which means it also never *revokes*. If an administrator
+     * had ever granted settings.manage to the assistente role through the UI,
+     * that drift would survive every re-seed. This migration closes that gap
+     * for existing databases. It is idempotent: a no-op when the role already
+     * lacks the permission.
+     */
+    public function up(): void
+    {
+        app(PermissionRegistrar::class)->forgetCachedPermissions();
+
+        $role = Role::where('name', 'assistente')->first();
+        $permission = Permission::where('name', 'settings.manage')->first();
+
+        if ($role && $permission && $role->hasPermissionTo($permission)) {
+            $role->revokePermissionTo($permission);
+        }
+
+        app(PermissionRegistrar::class)->forgetCachedPermissions();
+    }
+
+    /**
+     * Intentionally irreversible. Re-granting settings.manage to the
+     * assistente role would reintroduce the very ability this migration
+     * removes, so rolling back must not do it.
+     */
+    public function down(): void
+    {
+        // no-op
+    }
+};